New folder button #17422
Merged
New folder button #17422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brunopagno
force-pushed
the
impl/59901-new-folder-button
branch
2 times, most recently
from
7144554 to
c72190f
Compare
brunopagno
commented
Dec 13, 2024
.../src/app/shared/components/storages/location-picker-modal/location-picker-modal.component.ts
Outdated
Show resolved
Hide resolved
Kharonus
requested changes
Dec 13, 2024
...rc/app/shared/components/storages/location-picker-modal/location-picker-modal.component.html
Outdated
Show resolved
Hide resolved
.../src/app/shared/components/storages/location-picker-modal/location-picker-modal.component.ts
Outdated
Show resolved
Hide resolved
.../src/app/shared/components/storages/location-picker-modal/location-picker-modal.component.ts
Show resolved
Hide resolved
brunopagno
force-pushed
the
impl/59901-new-folder-button
branch
3 times, most recently
from
4704c93 to
755e181
Compare
brunopagno
force-pushed
the
impl/59901-new-folder-button
branch
from
b3c299b to
290974f
Compare
Kharonus
requested changes
Dec 19, 2024
frontend/src/app/shared/components/storages/storage/storage.component.ts
Show resolved
Hide resolved
brunopagno
force-pushed
the
impl/59901-new-folder-button
branch
from
290974f to
dd25efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/59901
What are you trying to accomplish?
New folder button on the location picker. This allows users to organise their files better.
Screenshots
Screencast.From.2024-12-16.06-49-13.mp4
What approach did you choose and why?
Using a
window.promptbecause it's the easiest to implement for now. Will enable us to move forward. There are follow ups that can be done to improve UX